C++: Fix false-positive in 'cpp/incorrect-allocation-error-handling'#6471
Merged
geoffw0 merged 3 commits intogithub:mainfrom Aug 11, 2021
Merged
Conversation
…er, but not a 'noexcept' specifier. This case was previously not reported because of the 'noexcept' specifier, and apparently the 'std::nothrow' case was broken all along.
geoffw0
reviewed
Aug 11, 2021
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6435.
Turns out we didn't recognize the
std::nothrowparameter invoid *operator new(std::size_t, const std::nothrow_t &);because it was hidden behind a reference type.We didn't catch this in the original PR because I included a
noexceptspecifier in all of the overloads where we had astd::nothrow_t ¶meter 🤦 .